Fix underflow when trading - #1969

@Flamefire @Flow86 Could it be that some permissions are missing for pullrequests from a fork? Because the ci above is not starting because of

2 workflows awaiting approval

Steps to reproduce:

• Build two storehouses
  

• Both storehouses have figures with one type, for example woodcutter
  

• Both storehouses have 2 woodcutters
  

• Send 1 woodcutter to ally storehouse
  

• Then 3 woodcutters are sent to the ally instead of 1
  

I don't see how 2 WHs are required for this bug. It seems the issue is that all woodcutters are sent instead of only the requested one. Can you explain?

@Flamefire @Flow86 Could it be that some permissions are missing for pullrequests from a fork? Because the ci above is not starting because of

2 workflows awaiting approval

That's intentional: Especially with AI PRs this avoids people flooding CI. Not sure if (still) required here though

If you have only one warehouse we get a overflow but this has now effect because the warehouse loop is left after the one woodcutter is sent from this warehouse. Only if there are more then one warehouse with the specific job the overflow has an effect. Because the count variable has an infite value and the count==0 check does never match.

Ah ok this is because of the AI. Must the approval be done after each commit or only for a newly created pull request? If this must be approved every time it could be difficult to fix unit-test and clang-tidy.

If you have only one warehouse we get a overflow but this has now effect because the warehouse loop is left after the one woodcutter is sent from this warehouse. Only if there are more then one warehouse with the specific job the overflow has an effect. Because the count variable has an infite value and the count==0 check does never match.

Ok so the issue is that it sends the requested number from the first WH and then basically ALL from the other warehouses due to count - available underflowing. Can you add that to the PR description?

Ah ok this is because of the AI. Must the approval be done after each commit or only for a newly created pull request? If this must be approved every time it could be difficult to fix unit-test and clang-tidy.

It's done for all PRs just because they could be AI.
Not fully sure. At least reviewers get a notification on pushes and can re-approve timely